ys2843 edited a comment on pull request #18288: URL: https://github.com/apache/incubator-mxnet/pull/18288#issuecomment-628867702
> Search feature looks great. > Nice to see we leveraging third-party to solve our search problem. > Q1. This feature is currently only for landing page right? > It isn't available on other pages right? > For e.g. not available in Python API > NDArray page right? > http://ec2-34-219-134-42.us-west-2.compute.amazonaws.com/api/python/docs/api/ndarray/index.html > > Can we document this point. And also add this functionality to rest of the pages in upcoming PRs? > > Q2 Is search suggestion pointing to the correct place? > When I search for copyto in 1.6 version on a laptop browser > It navigates to https://mxnet.apache.org/versions/1.6/api/python/docs/api/ndarray/ndarray.html?astype=#ndarray > > Isn't it supposed to go to the copyto operator specifically instead of the head of the div [ndarray] Thank you for reviewing! Good questions. Q1: Yes, it is available on all landing pages (that don't have a search bar currently), and not on any of the API docs pages. The reason is that while there is already a search bar on all API docs pages, in my opinion adding another one can confuse users. [Here is a similar example](https://pytorch.org/docs/stable/index.html), I think 1 search bar per page looks clear. Q2: Good point. This is related to improvement of search result, I am currently working on these issues. It is mainly about how we configure the web crawler to grab data from our website, and it does not require any code changes to MXNet website. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
