leezu commented on a change in pull request #18323:
URL: https://github.com/apache/incubator-mxnet/pull/18323#discussion_r427732782



##########
File path: tests/python/unittest/test_gluon_data.py
##########
@@ -138,52 +137,52 @@ def test_sampler():
     assert sorted(sum(list(rand_batch_keep), [])) == list(range(10))
 
 @with_seed()
-def test_datasets():
-    assert len(gluon.data.vision.MNIST(root='data/mnist')) == 60000
-    assert len(gluon.data.vision.MNIST(root='data/mnist', train=False)) == 
10000
-    assert len(gluon.data.vision.FashionMNIST(root='data/fashion-mnist')) == 
60000
-    assert len(gluon.data.vision.FashionMNIST(root='data/fashion-mnist', 
train=False)) == 10000
-    assert len(gluon.data.vision.CIFAR10(root='data/cifar10')) == 50000
-    assert len(gluon.data.vision.CIFAR10(root='data/cifar10', train=False)) == 
10000
-    assert len(gluon.data.vision.CIFAR100(root='data/cifar100')) == 50000
-    assert len(gluon.data.vision.CIFAR100(root='data/cifar100', 
fine_label=True)) == 50000
-    assert len(gluon.data.vision.CIFAR100(root='data/cifar100', train=False)) 
== 10000
+def test_datasets(tmpdir):
+    p = tmpdir.mkdir("test_datasets")
+    assert len(gluon.data.vision.MNIST(root=str(p.join('mnist')))) == 60000
+    assert len(gluon.data.vision.MNIST(root=str(p.join('mnist')), 
train=False)) == 10000
+    assert 
len(gluon.data.vision.FashionMNIST(root=str(p.join('fashion-mnist')))) == 60000
+    assert 
len(gluon.data.vision.FashionMNIST(root=str(p.join('fashion-mnist')), 
train=False)) == 10000
+    assert len(gluon.data.vision.CIFAR10(root=str(p.join('cifar10')))) == 50000
+    assert len(gluon.data.vision.CIFAR10(root=str(p.join('cifar10')), 
train=False)) == 10000
+    assert len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100')))) == 
50000
+    assert len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100')), 
fine_label=True)) == 50000
+    assert len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100')), 
train=False)) == 10000
 
 @with_seed()
-@pytest.mark.serial
-def test_datasets_handles():
-    assert len(gluon.data.vision.MNIST(root='data/mnist').__mx_handle__()) == 
60000
-    assert len(gluon.data.vision.MNIST(root='data/mnist', 
train=False).__mx_handle__()) == 10000
-    assert 
len(gluon.data.vision.FashionMNIST(root='data/fashion-mnist').__mx_handle__()) 
== 60000
-    assert len(gluon.data.vision.FashionMNIST(root='data/fashion-mnist', 
train=False).__mx_handle__()) == 10000
-    assert len(gluon.data.vision.CIFAR10(root='data/cifar10').__mx_handle__()) 
== 50000
-    assert len(gluon.data.vision.CIFAR10(root='data/cifar10', 
train=False).__mx_handle__()) == 10000
-    assert 
len(gluon.data.vision.CIFAR100(root='data/cifar100').__mx_handle__()) == 50000
-    assert len(gluon.data.vision.CIFAR100(root='data/cifar100', 
fine_label=True).__mx_handle__()) == 50000
-    assert len(gluon.data.vision.CIFAR100(root='data/cifar100', 
train=False).__mx_handle__()) == 10000
+def test_datasets_handles(tmpdir):
+    p = tmpdir.mkdir("test_datasets_handles")
+    assert 
len(gluon.data.vision.MNIST(root=str(p.join('mnist'))).__mx_handle__()) == 60000
+    assert len(gluon.data.vision.MNIST(root=str(p.join('mnist')), 
train=False).__mx_handle__()) == 10000
+    assert 
len(gluon.data.vision.FashionMNIST(root=str(p.join('fashion-mnist'))).__mx_handle__())
 == 60000
+    assert 
len(gluon.data.vision.FashionMNIST(root=str(p.join('fashion-mnist')), 
train=False).__mx_handle__()) == 10000
+    assert 
len(gluon.data.vision.CIFAR10(root=str(p.join('cifar10'))).__mx_handle__()) == 
50000
+    assert len(gluon.data.vision.CIFAR10(root=str(p.join('cifar10')), 
train=False).__mx_handle__()) == 10000
+    assert 
len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100'))).__mx_handle__()) 
== 50000
+    assert len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100')), 
fine_label=True).__mx_handle__()) == 50000
+    assert len(gluon.data.vision.CIFAR100(root=str(p.join('cifar100')), 
train=False).__mx_handle__()) == 10000
 
 @with_seed()
-def test_image_folder_dataset():
-    prepare_record()
-    dataset = gluon.data.vision.ImageFolderDataset('data/test_images')
+def test_image_folder_dataset(prepare_record):
+    print(prepare_record[:-8])

Review comment:
       https://docs.python.org/3/library/os.path.html#os.path.dirname ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to