cbalint13 commented on pull request #18365:
URL: https://github.com/apache/incubator-mxnet/pull/18365#issuecomment-632574190


   > Adopting the standard `BUILD_SHARED_LIBS` may take additional work to make 
sure all dependencies + the CI logic correctly handle the result. It would 
however result into a more "distro-friendly" build you quote, as the 
dependencies will also be built dynamically.
   
   Wow someone circumvent CI :1st_place_medal: 
   
   > 
   > But to keep things simple in this PR, it's fine to use an MXNet specific 
setting for now. I modified your PR slightly to reintroduce the MXNet specific 
option.
   
   Thank you very much @leezu !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to