ciyongch commented on pull request #18478: URL: https://github.com/apache/incubator-mxnet/pull/18478#issuecomment-642462904
Hi @szha @TaoLv @leezu , with the enhancement (check multiple license header and check *.md files) to `license_header.py`, there's some more files that missed a license header were exposed, **1) files missing a license header** The .github/*.md files were added by @szha , while some files were added in the year of 2015/2016. Inform the original/modified author and ask them help to (or get approval from them to) add the license header, may I have your suggestions to handle this? thanks! ``` [2020-06-11T06:58:34.163Z] license_header.py: ERROR File .github/ISSUE_TEMPLATE/bug_report.md doesn't have a valid license [2020-06-11T06:58:34.163Z] license_header.py: ERROR File .github/ISSUE_TEMPLATE/feature_request.md doesn't have a valid license [2020-06-11T06:58:34.163Z] license_header.py: ERROR File .github/ISSUE_TEMPLATE/flaky_test.md doesn't have a valid license [2020-06-11T06:58:34.163Z] license_header.py: ERROR File .github/PULL_REQUEST_TEMPLATE.md doesn't have a valid license [2020-06-11T06:58:34.418Z] license_header.py: ERROR File R-package/README.md doesn't have a valid license [2020-06-11T06:58:34.418Z] license_header.py: ERROR File example/image-classification/README.md doesn't have a valid license [2020-06-11T06:58:34.418Z] license_header.py: ERROR File example/image-classification/predict-cpp/README.md doesn't have a valid license [2020-06-11T06:58:34.418Z] license_header.py: ERROR File example/image-classification/symbols/README.md doesn't have a valid license [2020-06-11T06:58:34.418Z] license_header.py: ERROR File example/quantization/README.md doesn't have a valid license [2020-06-11T06:58:34.673Z] license_header.py: ERROR File julia/docs/src/api/optimizer.md doesn't have a valid license [2020-06-11T06:58:35.183Z] license_header.py: ERROR File tests/python-pytest/onnx/README.md doesn't have a valid license ``` **2) multiple license header issue** They're tracked in https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-638232751 ``` [2020-06-11T06:58:34.673Z] license_header.py: ERROR File python/mxnet/contrib/onnx/mx2onnx/_op_translations.py has multiple license [2020-06-11T06:58:34.673Z] license_header.py: ERROR File python/mxnet/contrib/onnx/mx2onnx/export_onnx.py has multiple license [2020-06-11T06:58:34.928Z] license_header.py: ERROR File src/operator/contrib/nn/modulated_deformable_im2col.cuh has multiple license [2020-06-11T06:58:34.928Z] license_header.py: ERROR File src/operator/contrib/nn/modulated_deformable_im2col.h has multiple license [2020-06-11T06:58:34.928Z] license_header.py: ERROR File src/operator/numpy/np_einsum_op.cc has multiple license [2020-06-11T06:58:34.928Z] license_header.py: ERROR File src/operator/numpy/np_einsum_path_op-inl.h has multiple license ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
