[GitHub] eric-haibin-lin commented on a change in pull request #8331: [sparse] slice for csr on two dimensions, cpu implementation

[GitBox]

eric-haibin-lin commented on a change in pull request #8331: [sparse] slice for 
csr on two dimensions, cpu implementation
URL: https://github.com/apache/incubator-mxnet/pull/8331#discussion_r147855365
 
 

 ##########
 File path: src/operator/tensor/matrix_op-inl.h
 ##########
 @@ -601,18 +590,127 @@ void SliceCsrImpl(const SliceParam &param, const 
OpContext& ctx,
   });
 }
 
+// slice a CSRNDArray for two dimensions
 
 Review comment:
   Let's add more documentation for the kernels like this one 
https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/dot-inl.cuh#L40

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services