DickJC123 commented on a change in pull request #8470: Fix sparse dot test
failure due to launching kernel when nnr = 0
URL: https://github.com/apache/incubator-mxnet/pull/8470#discussion_r147858681
##########
File path: tests/python/unittest/test_sparse_operator.py
##########
@@ -1217,6 +1218,13 @@ def test_dot_csr(lhs_shape, rhs_shape, rhs_stype,
trans_lhs, lhs_density, rhs_de
test_dot_csr(lhs_shape, (lhs_shape[0], rnd.randint(1, 10)),
'row_sparse', True, lhs_d, rhs_d)
+def test_sparse_dot_twice():
Review comment:
I agree here. I recommend creating some input that creates a 0 nnr, then
proving the test fails on the existing codebase, then finally is fixed by the
PR. I supplied the seeded test case just as a way to reproduce the problem,
not as a reliable way to test the function going forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
