wkcn commented on a change in pull request #18644: URL: https://github.com/apache/incubator-mxnet/pull/18644#discussion_r447749228
########## File path: tests/python/unittest/test_gluon.py ########## @@ -665,6 +665,34 @@ def transpose(shape): assert (layer(x).shape==ceil_out_shape) +@with_seed() +@pytest.mark.parametrize('cudnn_off', [True, False]) +@pytest.mark.parametrize('variable', ['running_var', 'running_mean']) +def test_batchnorm_backward_synchronization(cudnn_off, variable): + """ + Tests if synchronization of BatchNorm running variables is done correctly. + If not, the test sometimes fails - depending on the timing. + """ + ctx = mx.cpu() if cudnn_off else mx.gpu() Review comment: It should be `ctx = mx.test_utils.default_context()`. In CI, there are tests on CPU and GPU. We don't need to specify the context. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org