xidulu commented on a change in pull request #18689:
URL: https://github.com/apache/incubator-mxnet/pull/18689#discussion_r453139086
##########
File path: python/mxnet/gluon/probability/distributions/utils.py
##########
@@ -48,7 +51,10 @@ def compute(value):
"""Return digamma(value)
"""
if isinstance(value, Number):
- return sc.digamma(value, dtype='float32')
+ if sc is not None:
+ return sc.digamma(value, dtype='float32')
Review comment:
Since _value_ is a a python scalar, the default output’s dtype would be
float64, which is inconsistent DeepNumpy’s behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
