DickJC123 commented on a change in pull request #18622: URL: https://github.com/apache/incubator-mxnet/pull/18622#discussion_r458310059
########## File path: src/common/cuda/rtc.cc ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "mxnet/base.h" + +#if MXNET_USE_CUDA + +#include <nvrtc.h> + +#include <mutex> +#include <string> +#include <fstream> +#include <unordered_map> +#include <vector> + +#include "rtc.h" +#include "rtc/half-inl.h" +#include "rtc/util-inl.h" +#include "rtc/forward_functions-inl.h" +#include "rtc/backward_functions-inl.h" +#include "rtc/vectorization-inl.h" +#include "rtc/special_functions-inl.h" +#include "rtc/reducer-inl.h" +#include "utils.h" + + +namespace mxnet { +namespace common { +namespace cuda { +namespace rtc { + +std::mutex lock; + +namespace util { + +std::string to_string(OpReqType req) { + switch (req) { + case kNullOp: + return "OpReqType::kNullOp"; + case kWriteTo: + case kWriteInplace: + return "OpReqType::kWriteTo"; + case kAddTo: + return "OpReqType::kAddTo"; + } + LOG(FATAL) << "Unrecognized req."; + return ""; +} + +} // namespace util + +namespace { + +// Obtain compilation log from the program. +std::string GetCompileLog(nvrtcProgram program) { + size_t log_size_including_null; + NVRTC_CALL(nvrtcGetProgramLogSize(program, &log_size_including_null)); + // For most std::string implementations, this is probably 1 char bigger than needed. OK though. Review comment: You might be surprised to hear that I'm actually ambivalent which way we go here. The way I see it, the two approaches are: 1. Existing approach- works, more conservative coding style, has unneeded resize() (2 lines) 2. Proposed approach- simpler, small bit faster due to eliminating resize(), closer to 'bleeding edge' of C++11 standard I propose we go with approach 2, without the resize(), as suggested by @leezu. However, let's leave in the comment that I included in my code snippet above. If the RTC ever starts segfaulting, and I'm pulled in to debug it, the comment would be a sufficient reminder to me to revert to the former approach to eliminate compiler standard non-compliance as a possible cause. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
