rahul003 commented on a change in pull request #8294: NCCL integration
URL: https://github.com/apache/incubator-mxnet/pull/8294#discussion_r148720629
##########
File path: src/kvstore/comm.h
##########
@@ -46,8 +64,8 @@ class Comm {
/**
* \brief init key with the data shape and storage shape
*/
- virtual void Init(int key, const NDArrayStorageType stype,
- const TShape& shape, int dtype = mshadow::kFloat32) = 0;
+ virtual void Init(int key, const NDArrayStorageType stype, const TShape&
shape,
+ int dtype = mshadow::kFloat32, Context pinned_ctx =
Context::CPUPinned(0)) = 0;
Review comment:
Are you changing the pinnned context to something other than CPU in
kVStoreNCCL? Or is this change just to generalize the function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
