eric-haibin-lin commented on a change in pull request #8259: check_format of
sparse ndrray
URL: https://github.com/apache/incubator-mxnet/pull/8259#discussion_r149508628
##########
File path: tests/python/unittest/test_sparse_ndarray.py
##########
@@ -735,6 +735,58 @@ def test_sparse_nd_exception():
assert_exception(mx.nd.sparse.zeros, ValueError,
"invalid_stype", (2,2))
+def test_sparse_nd_check_format():
+ """ test check_format for sparse ndarray """
+ def check_csr_format_exception(data_list, indices_list, indptr_list,
shape):
Review comment:
We can use assertRaises to make the code cleaner
https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/common.py#L27
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
