yajiedesign commented on a change in pull request #8572: use first class cuda with cmake 3.9 and cuda9.0 support URL: https://github.com/apache/incubator-mxnet/pull/8572#discussion_r149829711
########## File path: CMakeLists.txt ########## @@ -128,14 +152,20 @@ endif() include_directories(${CMAKE_CURRENT_SOURCE_DIR}/include) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/src) -if(EXISTS ${PROJECT_SOURCE_DIR}/mshadow/cmake) - include(mshadow/cmake/mshadow.cmake) +if(FIRST_CUDA) Review comment: https://cmake.org/cmake/help/latest/release/3.8.html?highlight=cuda#cuda ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services