cjolivier01 commented on a change in pull request #8680: Fix cmake library path
when installing python package
URL: https://github.com/apache/incubator-mxnet/pull/8680#discussion_r152616626
##########
File path: python/mxnet/libinfo.py
##########
@@ -31,7 +31,7 @@ def find_lib_path():
"""
curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))
api_path = os.path.join(curr_path, '../../lib/')
- cmake_build_path = os.path.join(curr_path, '../../build/Release/')
+ cmake_build_path = os.path.join(curr_path, '../../build/')
Review comment:
CMake often tends to make a separate output directory for each build
configuration "Debug", "Release", "RelWithDebInfo", etc. (when told to do so,
for example by CLion, except it calls it cmake-build-debug,
cmake-build-release, etc.). While I am not crazy about trying to guess the
cmake output directory, I think explicitly pointing to "Release" when what you
think you're running is "Debug" is dangerous.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
