piiswrong commented on a change in pull request #8779: [Image] add random
lighting
URL: https://github.com/apache/incubator-mxnet/pull/8779#discussion_r152695074
##########
File path: src/operator/image/image_random-inl.h
##########
@@ -290,11 +291,107 @@ static void RandomColorJitter(const nnvm::NodeAttrs
&attrs,
const std::vector<TBlob> &outputs) {
}
+struct AdjustLightingParam : public dmlc::Parameter<AdjustLightingParam> {
+ nnvm::Tuple<float> alpha_rgb;
+ nnvm::Tuple<float> eigval;
+ nnvm::Tuple<float> eigvec;
+ DMLC_DECLARE_PARAMETER(AdjustLightingParam) {
+ DMLC_DECLARE_FIELD(alpha_rgb)
+ .set_default({0, 0, 0})
+ .describe("The lighting alphas for the R, G, B channels.");
+ DMLC_DECLARE_FIELD(eigval)
+ .describe("Eigen value.")
+ .set_default({ 55.46, 4.794, 1.148 });
+ DMLC_DECLARE_FIELD(eigvec)
+ .describe("Eigen vector.")
+ .set_default({ -0.5675, 0.7192, 0.4009,
+ -0.5808, -0.0045, -0.8140,
+ -0.5808, -0.0045, -0.8140 });
+ }
+};
+
+struct RandomLightingParam : public dmlc::Parameter<RandomLightingParam> {
+ float alpha_std;
+ nnvm::Tuple<float> eigval;
+ nnvm::Tuple<float> eigvec;
+ DMLC_DECLARE_PARAMETER(RandomLightingParam) {
+ DMLC_DECLARE_FIELD(alpha_std)
+ .set_default(0.05)
+ .describe("Level of the lighting noise.");
+ DMLC_DECLARE_FIELD(eigval)
+ .describe("Eigen value.")
+ .set_default({ 55.46, 4.794, 1.148 });
+ DMLC_DECLARE_FIELD(eigvec)
+ .describe("Eigen vector.")
+ .set_default({ -0.5675, 0.7192, 0.4009,
+ -0.5808, -0.0045, -0.8140,
+ -0.5808, -0.0045, -0.8140 });
+ }
+};
+
+void AdjustLightingImpl(uint8_t* dst, const uint8_t* src,
+ float alpha_r, float alpha_g, float alpha_b,
+ const nnvm::Tuple<float> eigval, const
nnvm::Tuple<float> eigvec,
+ int H, int W) {
+ alpha_r *= eigval[0];
+ alpha_g *= eigval[1];
+ alpha_b *= eigval[2];
+ float pca_r = alpha_r * eigvec[0] + alpha_g * eigvec[1] + alpha_b *
eigvec[2];
+ float pca_g = alpha_r * eigvec[3] + alpha_g * eigvec[4] + alpha_b *
eigvec[5];
+ float pca_b = alpha_r * eigvec[6] + alpha_g * eigvec[7] + alpha_b *
eigvec[8];
+ for (int i = 0; i < H; i++) {
+ for (int j = 0; j < W; j++) {
Review comment:
merge to one loop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
