piiswrong commented on a change in pull request #8302: Refactor operators &
MKLDNN
URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r156271162
##########
File path: src/operator/nn/cudnn/cudnn_convolution-inl.h
##########
@@ -42,9 +42,19 @@ namespace op {
* \brief The Operator used to perform convolution using cuDNN kernels.
*/
template<typename DType>
-class CuDNNConvolutionOp : public Operator {
+class CuDNNConvolutionOp {
public:
- explicit CuDNNConvolutionOp(const ConvolutionParam& param,
+ CuDNNConvolutionOp() {
+ CUDNN_CALL(cudnnCreateTensorDescriptor(&in_desc_));
+ CUDNN_CALL(cudnnCreateTensorDescriptor(&out_desc_));
+ CUDNN_CALL(cudnnCreateTensorDescriptor(&bias_desc_));
+ CUDNN_CALL(cudnnCreateFilterDescriptor(&filter_desc_));
+ CUDNN_CALL(cudnnCreateConvolutionDescriptor(&forward_conv_desc_));
+ CUDNN_CALL(cudnnCreateConvolutionDescriptor(&back_conv_desc_));
+ CUDNN_CALL(cudnnCreateConvolutionDescriptor(&back_conv_desc_w_));
+ }
+
+ void Init(const ConvolutionParam& param,
Review comment:
Init calls InitDescriptors, which init both forward and backward
descriptors. But its unnecessary since each time you only use either forward or
backward
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
