sbodenstein opened a new pull request #9306: Sequence Operator Improvements URL: https://github.com/apache/incubator-mxnet/pull/9306 ## Description ## This PR does the following: - Adds an optional argument `axis` to `SequenceLast`, `SequenceMask` and `SequenceReverse`. The default is `axis=0`. Values for `axis=1` and `axis=0` are implemented for `SequenceLast` and `SequenceMask`. - Rigorous tests are added for all sequence ops. - Bug in `SequenceMask` was fixed (incorrect behaviour for `kAddTo`). - Performance improvements: `SequenceLast` avoids any movement of data to the CPU, and uses a much faster implementation similar to `pick`. `SequenceMask` now supports inplace. Axis support will be added to `SequenceReverse` in a separate PR. ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes are complete (i.e. I finished coding on this PR) - [] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
