zheng-da commented on a change in pull request #8302: Refactor operators & MKLDNN URL: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r162506606
########## File path: include/mxnet/ndarray.h ########## @@ -184,11 +135,17 @@ class NDArray { const TBlob &data, const std::vector<TBlob> &aux_data, int dev_id) : ptr_(std::make_shared<Chunk>(stype, data, aux_data, dev_id)), shape_(shape), dtype_(data.type_flag_), storage_type_(stype), entry_({nullptr, 0, 0}) { -#if MKL_EXPERIMENTAL == 1 - Mkl_mem_ = std::make_shared<MKLMemHolder>(); -#endif } + inline bool IsView() const { Review comment: i'll add comments to explain why we need it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services