lebeg commented on issue #9727: Refactored storage handling URL: https://github.com/apache/incubator-mxnet/pull/9727#issuecomment-363878445 > What's the benefit of using shared_ptr for storage? The ownership of memory storage::Handles are pointing to with their dptr is protected from extinction and managed by the shared_ptr. > Chunks are already in shared_ptr and never copied anyway. There are other places which use storage::Handle and mostly as just a pointer to some allocated memory without access protection. > How much performance is lost by refactoring to shared_ptr and std::function? * There is an additional reference count stored on the heap next to each Handle * 1 indirection when constructing a TBlob
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
