piiswrong commented on a change in pull request #9770: eye operator, for
default storage type
URL: https://github.com/apache/incubator-mxnet/pull/9770#discussion_r167662010
##########
File path: tests/python/unittest/test_ndarray.py
##########
@@ -736,6 +736,14 @@ def test_output():
assert_almost_equal(out.asnumpy(), ones.asnumpy() * 2)
arange_out = mx.nd.arange(0, 20, dtype='int64')
assert_almost_equal(arange_out.asnumpy(), np.arange(0, 20))
+ N_array = np.random.randint(1, high=3, size=3)
+ M_array = np.random.randint(1, high=3, size=3)
+ k_array = np.random.randint(-5, high=5, size=3)
Review comment:
Could you run some more trials?
At least locally & with larger ranges. Just to verify if there are edge cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
