szha commented on a change in pull request #9492: fix print_summary bug and add 
groups of convolution
URL: https://github.com/apache/incubator-mxnet/pull/9492#discussion_r168318967
 
 

 ##########
 File path: python/mxnet/visualization.py
 ##########
 @@ -134,20 +134,26 @@ def print_layer_summary(node, out_shape):
                             pre_filter = pre_filter + int(shape[0])
         cur_param = 0
         if op == 'Convolution':
-            if ("no_bias" in node["attrs"]) and int(node["attrs"]["no_bias"]):
-                cur_param = pre_filter * int(node["attrs"]["num_filter"])
+            if "no_bias" in node["attrs"] and node["attrs"]["no_bias"] == 
'True':
+                num_group = int(node["attrs"]["num_group"]) if \
+                   "num_group" in node["attrs"] else 1
 
 Review comment:
   int(node['attrs'].get('num_group', '1')). same below.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to