cjolivier01 closed pull request #9832: Ability to not build examples during the 
build of the cpp package.
URL: https://github.com/apache/incubator-mxnet/pull/9832
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/cpp-package/CMakeLists.txt b/cpp-package/CMakeLists.txt
index 890a441ac6..f7fbc77e1a 100644
--- a/cpp-package/CMakeLists.txt
+++ b/cpp-package/CMakeLists.txt
@@ -1,21 +1,23 @@
 if(USE_CPP_PACKAGE)
 
-set(CPP_PACKAGE_OP_H_HEADER ${CMAKE_CURRENT_LIST_DIR}/include/mxnet-cpp/op.h)
+  set(CPP_PACKAGE_OP_H_HEADER ${CMAKE_CURRENT_LIST_DIR}/include/mxnet-cpp/op.h)
 
-if(MSVC)
-  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /utf-8")
-endif(MSVC)
+  if(MSVC)
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /utf-8")
+  endif(MSVC)
 
-add_custom_target(
-  cpp_package_op_h ALL
-  BYPRODUCTS ${CPP_PACKAGE_OP_H_HEADER}
-  MAIN_DEPENDENCY mxnet
-  DEPENDS mxnet ${CMAKE_CURRENT_SOURCE_DIR}/scripts/OpWrapperGenerator.py
-  COMMAND echo "Running: OpWrapperGenerator.py"
-  COMMAND python OpWrapperGenerator.py $<TARGET_FILE:mxnet>
-  WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/scripts
-)
+  add_custom_target(
+    cpp_package_op_h ALL
+    BYPRODUCTS ${CPP_PACKAGE_OP_H_HEADER}
+    MAIN_DEPENDENCY mxnet
+    DEPENDS mxnet ${CMAKE_CURRENT_SOURCE_DIR}/scripts/OpWrapperGenerator.py
+    COMMAND echo "Running: OpWrapperGenerator.py"
+    COMMAND python OpWrapperGenerator.py $<TARGET_FILE:mxnet>
+    WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/scripts
+  )
 
-add_subdirectory(example)
+  if(NOT DO_NOT_BUILD_EXAMPLES)
+    add_subdirectory(example)
+  endif()
 
 endif()


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to