piiswrong commented on a change in pull request #8915: NVLink communication pattern updated URL: https://github.com/apache/incubator-mxnet/pull/8915#discussion_r170374385
########## File path: src/kvstore/comm.h ########## @@ -22,30 +22,29 @@ */ #ifndef MXNET_KVSTORE_COMM_H_ #define MXNET_KVSTORE_COMM_H_ +#define NVLINK_SUPPORT 4 Review comment: what's this? Can we avoid magic numbers? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
