reminisce commented on a change in pull request #9981: [fix issue#9976] The assignment problem in NDArray URL: https://github.com/apache/incubator-mxnet/pull/9981#discussion_r172037698
########## File path: tests/python/unittest/test_ndarray.py ########## @@ -1099,6 +1099,39 @@ def test_assign_float_value_to_ndarray(): b[0] = a[0] assert same(a, b.asnumpy()) +@with_seed() +def test_ndarray_assignment(): Review comment: 1. Add issue link as code comment. 2. Change the function name to a special one since this is only for testing special cases. General cases have been covered by `test_ndarray_indexing`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services