KellenSunderland commented on a change in pull request #10075: Fix CMake build issue with MKL. URL: https://github.com/apache/incubator-mxnet/pull/10075#discussion_r173954308
########## File path: ci/docker/runtime_functions.sh ########## @@ -278,8 +278,6 @@ build_ubuntu_gpu_cmake() { cmake \ -DUSE_CUDA=1 \ -DUSE_CUDNN=1 \ - -DUSE_MKLML_MKL=0 \ - -DUSE_MKLDNN=0 \ Review comment: build_ubuntu_gpu_cmake_mkldnn explicitly turns _on_ MKL, which is fine because if you're opting into a feature you know what that feature is. My intent here was to test the default behaviour (what a user is likely to do). I.e. what happens when you don't explicitly change any other option other than CUDA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services