spidyDev commented on a change in pull request #10118: [MXNET-106][ONNX-MXNET]
Fix Maxpool and BatchNorm operator.
URL: https://github.com/apache/incubator-mxnet/pull/10118#discussion_r174673619
##########
File path: python/mxnet/contrib/onnx/_import/import_onnx.py
##########
@@ -110,6 +110,10 @@ def from_onnx(self, graph):
self._nodes[name_input] = symbol.Variable(name=name_input)
self._renames[i.name] = name_input
+ # For storing arg and aux params for the graph.
+ auxDict = {}
+ argDict = {}
Review comment:
We don' t need class variables . Local variables should suffice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
