marcoabreu commented on a change in pull request #10108: [MXNET-99] Upgrade to
cuda 9.1 cudnn 7
URL: https://github.com/apache/incubator-mxnet/pull/10108#discussion_r175963691
##########
File path: python/mxnet/model.py
##########
@@ -848,7 +848,7 @@ def fit(self, X, y=None, eval_data=None, eval_metric='acc',
# init optmizer
if isinstance(self.optimizer, str):
batch_size = data.batch_size
- if kvstore and 'dist' in kvstore.type and not '_async' in
kvstore.type:
+ if kvstore and 'dist' in kvstore.type and '_async' not in
kvstore.type:
batch_size *= kvstore.num_workers
Review comment:
Pylint started to complain just now, the reason is stated above.
We don't have the tools to check whether this exact code path is unit
tested. I didn't really bother to search for it since this change is logically
equivalent.
I have supplied you with code to prove that the outcome is identical. Please
provide proof that my reformatting is not equivalent if you would like to
continue this discussion. The actions of the underlying code are not part of
this PR and thus out of scope - I will not check for unit tests here since I
made no logical modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
