szha commented on a change in pull request #10108: [MXNET-99] Upgrade to cuda
9.1 cudnn 7
URL: https://github.com/apache/incubator-mxnet/pull/10108#discussion_r175965378
##########
File path: python/mxnet/model.py
##########
@@ -848,7 +848,7 @@ def fit(self, X, y=None, eval_data=None, eval_metric='acc',
# init optmizer
if isinstance(self.optimizer, str):
batch_size = data.batch_size
- if kvstore and 'dist' in kvstore.type and not '_async' in
kvstore.type:
+ if kvstore and 'dist' in kvstore.type and '_async' not in
kvstore.type:
batch_size *= kvstore.num_workers
Review comment:
@cjolivier01 you asked other committers to respect your "request changes"
reviews as vetos before, hence I assumed that your "request changes" review in
this occasion should be considered veto too. Should I change my assumption? If
so, what's the criteria, so that we could avoid miscommunication. If not, my
request stands.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
