cjolivier01 commented on a change in pull request #10108: [MXNET-99] Upgrade to
cuda 9.1 cudnn 7
URL: https://github.com/apache/incubator-mxnet/pull/10108#discussion_r175968730
##########
File path: python/mxnet/model.py
##########
@@ -848,7 +848,7 @@ def fit(self, X, y=None, eval_data=None, eval_metric='acc',
# init optmizer
if isinstance(self.optimizer, str):
batch_size = data.batch_size
- if kvstore and 'dist' in kvstore.type and not '_async' in
kvstore.type:
+ if kvstore and 'dist' in kvstore.type and '_async' not in
kvstore.type:
batch_size *= kvstore.num_workers
Review comment:
@szha I’m not sure where you’re going with that comment. Veto is an Apache
concept to block a code merge. If you know of a “don’t merge until either
questions are answered sufficiently or code changes are made” button, then
please point it out. In the past, unanswered questions have led to last-minute
fiascos (ie MKL changes PR).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
