cjolivier01 commented on a change in pull request #10161: Fix mem alignment.
URL: https://github.com/apache/incubator-mxnet/pull/10161#discussion_r175980052
##########
File path: include/mxnet/base.h
##########
@@ -365,6 +365,10 @@ inline std::ostream& operator<<(std::ostream &out, const
Context &ctx) {
#define MXNET_DESCRIBE(...) describe(__VA_ARGS__ "\n\nFrom:" __FILE__ ":"
STRINGIZE(__LINE__))
#define ADD_FILELINE "\n\nDefined in " __FILE__ ":L" STRINGIZE(__LINE__)
+#if MXNET_USE_MKLDNN == 1
+static constexpr size_t MKLDNNAlign = 64;
Review comment:
I don’t think you need ‘static’ here, do you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
