cjolivier01 commented on a change in pull request #8246: Continued Work on
Advanced Indexing
URL: https://github.com/apache/incubator-mxnet/pull/8246#discussion_r175982651
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -1858,10 +2174,8 @@ def full(shape, val, ctx=None, dtype=mx_real_t,
out=None):
>>> mx.nd.full((1, 2), 2.0, dtype='float16').asnumpy()
array([[ 2., 2.]], dtype=float16)
"""
- if ctx is None:
- ctx = Context.default_ctx
- dtype = mx_real_t if dtype is None else dtype
- out = _internal._full(shape=shape, ctx=ctx, dtype=dtype, value=val,
out=out)
+ out = empty(shape, ctx, dtype) if out is None else out
Review comment:
ok thanks for digging that up!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
