eric-haibin-lin commented on a change in pull request #10183: [MXNET-120]
Float16 support for distributed training
URL: https://github.com/apache/incubator-mxnet/pull/10183#discussion_r176900404
##########
File path: src/kvstore/kvstore_dist.h
##########
@@ -228,17 +228,18 @@ class KVStoreDist : public KVStoreLocal {
RunContext rctx, Engine::CallbackOnComplete cb) {
// convert to ps keys
size_t size = recv_buf.shape().Size();
-
+ int dtype = recv_buf.dtype();
+ int elem_size = mshadow::mshadow_sizeof(dtype);
Review comment:
would `num_bytes` be a better name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
