cjolivier01 commented on a change in pull request #9933: [MXNET-23] Adding support to profile kvstore server during distributed training URL: https://github.com/apache/incubator-mxnet/pull/9933#discussion_r176945010
########## File path: include/mxnet/c_api.h ########## @@ -218,25 +218,35 @@ MXNET_DLL int MXNotifyShutdown(); * \param num_params Number of parameters * \param keys array of parameter keys * \param vals array of parameter values + * \param kvstoreHandle handle to kvstore * \return 0 when success, -1 when failure happens. */ -MXNET_DLL int MXSetProfilerConfig(int num_params, const char* const* keys, const char* const* vals); +MXNET_DLL int MXSetProfilerConfig(int num_params, const char* const* keys, const char* const* vals, Review comment: if you do, it should be with some macro that will be nothing in C. because if you include this header from a C file, it will choke on that default argument ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
