cjolivier01 commented on a change in pull request #10317: [MXNET-264] Improve
performance of MKLDNN in small batch sizes.
URL: https://github.com/apache/incubator-mxnet/pull/10317#discussion_r179326420
##########
File path: src/operator/nn/lrn-inl.h
##########
@@ -58,8 +58,35 @@ struct LRNParam : public dmlc::Parameter<LRNParam> {
DMLC_DECLARE_FIELD(nsize)
.describe("normalization window width in elements.");
}
+
+ bool operator==(const LRNParam& other) const {
+ return (fabs(this->alpha - other.alpha) < 1e-6 &&
Review comment:
it’s better to check the nsize first because it’s a far less expensive check
than fabs()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
