wentingj commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r182640860
########## File path: src/operator/quantization/quantized_conv.cc ########## @@ -86,12 +89,10 @@ bool QuantizedConvType(const nnvm::NodeAttrs& attrs, const ConvolutionParam& param = nnvm::get<ConvolutionParam>(attrs.parsed); CHECK_EQ(in_type->size(), param.no_bias? 6U : 9U); CHECK_EQ(out_type->size(), 3U); - TYPE_ASSIGN_CHECK(*in_type, 0, mshadow::kInt8); Review comment: Since mkldnn support u8 input data type while cudnn use s8, so we move input data type check into FComputeEx. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
