ThomasDelteil commented on a change in pull request #10623: [MXNET-339] Add 
warning on input data for RNN for layout NTC
URL: https://github.com/apache/incubator-mxnet/pull/10623#discussion_r183123088
 
 

 ##########
 File path: python/mxnet/gluon/rnn/rnn_layer.py
 ##########
 @@ -286,6 +286,9 @@ class RNN(_RNNLayer):
     Inputs:
         - **data**: input tensor with shape `(sequence_length, batch_size, 
input_size)`
           when `layout` is "TNC". For other layouts dimensions are permuted 
accordingly.
+          Be aware that a `transpose` operation with a ndarray results in a 
new allocation of
 
 Review comment:
   That was my original formulation but then I realized that if users did a 
ndarray.transpose to TNC before loading the data then it would be pointless 
advice 😄 And I didn't want to either explicitly say that numpy is faster at 
transposing since it is copy-free. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to