ThomasDelteil commented on a change in pull request #10628: [MXNET-342] Fix the
multi worker Dataloader
URL: https://github.com/apache/incubator-mxnet/pull/10628#discussion_r183131243
##########
File path: python/mxnet/gluon/data/dataloader.py
##########
@@ -112,6 +113,9 @@ def default_mp_batchify_fn(data):
def worker_loop(dataset, key_queue, data_queue, batchify_fn):
"""Worker loop for multiprocessing DataLoader."""
+ if isinstance(dataset, RecordFileDataset):
Review comment:
@piiswrong we could also have a `reload` method on `Dataset` that does
nothing for all dataset except for the RecordFileDataset ones, that way there
is no special casing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
