zheng-da commented on a change in pull request #10433: [MXNET-290] MKLDNN support for model quantization URL: https://github.com/apache/incubator-mxnet/pull/10433#discussion_r183132722
########## File path: src/operator/nn/mkldnn/mkldnn_base.cc ########## @@ -211,6 +211,7 @@ mkldnn_memory_format_t GetDefaultFormat(mkldnn::memory::desc desc) { case mkldnn_hwio: case mkldnn_OIhw8i8o: case mkldnn_OIhw16i16o: + case mkldnn_OIhw4i16o4i: Review comment: i agree. If it's not related, it's better to take it out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services