zheng-da commented on a change in pull request #10666: [MXNET-359] fix checks on convolution parameters in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/10666#discussion_r183631914
########## File path: src/operator/nn/mkldnn/mkldnn_convolution.cc ########## @@ -88,26 +91,23 @@ static mkldnn::convolution_backward_data::primitive_desc GetConvBwdData( auto weight_md = GetWeightDesc(weights, param.num_group); auto out_md = GetMemDesc(output); auto engine = CpuEngine::Get()->get_engine(); + CHECK_GE(param.stride.ndim(), 2U); Review comment: after ONNX is fixed, this should be CHECK_EQ. I didn't know if ONNIX would be fixed when I submitted the PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services