anirudh2290 commented on a change in pull request #10676: fix for asymmetric
padding
URL: https://github.com/apache/incubator-mxnet/pull/10676#discussion_r183877365
##########
File path: tests/python-pytest/onnx/onnx_test.py
##########
@@ -124,12 +124,13 @@ def test_super_resolution_example():
assert sym.list_outputs()[0] == 'reshape5_output'
attrs_keys = sym.attr_dict().keys()
- assert len(attrs_keys) == 19
+ assert len(attrs_keys) == 23
for i, key_item in enumerate(['reshape4', 'convolution2', 'convolution0',
'transpose0', '6', 'reshape0', 'reshape2',
'reshape3', '3', 'reshape1', '5', '4', '7',
'convolution1', '9', '2', 'convolution3',
- 'reshape5', '8']):
+ 'reshape5', '8', 'pad1', 'pad0', 'pad3',
Review comment:
can we also add an assertRaises test for the asymmetric case ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
