anirudhacharya commented on a change in pull request #10676: fix for asymmetric
padding
URL: https://github.com/apache/incubator-mxnet/pull/10676#discussion_r183897755
##########
File path: python/mxnet/contrib/onnx/_import/op_translations.py
##########
@@ -214,9 +214,25 @@ def conv(attrs, inputs, cls):
new_attrs = translation_utils._fix_bias('Convolution', new_attrs,
len(inputs))
new_attrs = translation_utils._fix_channels('Convolution', new_attrs,
inputs, cls)
-
- return 'Convolution', new_attrs, inputs
-
+ kernel = new_attrs['kernel']
+ stride = new_attrs['stride'] if 'stride' in new_attrs else []
+ padding = new_attrs['pad'] if 'pad' in new_attrs else []
+ dilations = new_attrs['dilate'] if 'dilate' in new_attrs else []
+ num_filter = new_attrs['num_filter']
+ num_group = new_attrs['num_group']
+ no_bias = new_attrs['no_bias'] if 'no_bias' in new_attrs else 0
Review comment:
Currently convolution operator is being tested with padding and without
padding. Here are some of the tests that are run -
https://github.com/onnx/onnx/blob/master/docs/Operators.md#examples-9
More tests for corner cases with asymmetric padding can be added. These
tests will need to be added to the ONNX repo here -
https://github.com/onnx/onnx/blob/master/onnx/backend/test/case/node/conv.py
Will include adding more tests in our backlog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
