yzhliu commented on a change in pull request #10660: [MXNET-357][WIP] New Scala
API Design
URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r183909390
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
##########
@@ -136,20 +98,67 @@ private[mxnet] object SymbolImplMacros {
result
}
+ // Convert C++ Types to Scala Types
+ private def typeConversion(in : String, argType : String = "") : String = {
+ in match {
+ case "Shape(tuple)" | "ShapeorNone" => "Shape"
+ case "Symbol" | "NDArray" | "NDArray-or-Symbol" => "Symbol"
+ case "Symbol[]" | "NDArray[]" | "NDArray-or-Symbol[]" |
"SymbolorSymbol[]" => "Array[Symbol]"
+ case "float" | "real_t" => "MXFloat"
+ case "int" | "intorNone" | "int(non-negative)" => "Int"
+ case "long" | "long(non-negative)" => "Long"
+ case "double" => "Double"
+ case "string" => "String"
+ case "boolean" => "Boolean"
+ case "tupleof<float>" => "Any"
+ case default => throw new IllegalArgumentException(
+ s"Invalid type for args: $default, $argType")
+ }
+ }
+
+ private def argumentCleaner(argType : String) : (String, Boolean) = {
+ val spaceRemoved = argType.replaceAll("\\s+", "")
+ var commaRemoved : Array[String] = new Array[String](0)
Review comment:
looks like you can write
```
val commaRemoved = if ... else ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
