haojin2 commented on a change in pull request #10645: [MXNET-354] Support elemwise_add/sub between dense and row sparse tensors on CPU/GPU URL: https://github.com/apache/incubator-mxnet/pull/10645#discussion_r184160050
########## File path: src/operator/tensor/elemwise_binary_op-inl.h ########## @@ -450,6 +450,85 @@ void ElemwiseBinaryOp::DnsCsrDnsOp(mshadow::Stream<cpu> *s, }); } +/*! + * \brief Kernel for performing elemwise op between dense and rsp tensor + * \param i global thread id + * \param req type of request + * \param out output array + * \param dns_data data array of dense input + * \param rsp_data data array of rsp input + * \param rsp_indices indices array of rsp input + * \param num_rows number of rows of both inputs + * \param nz_rows number of non-zero rows of rsp tensor + * \param num_cols number of columns of both inputs + */ +template<typename OP> Review comment: Done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services