lanking520 commented on a change in pull request #10660: [MXNET-357] New Scala
API Design (Symbol)
URL: https://github.com/apache/incubator-mxnet/pull/10660#discussion_r185307663
##########
File path:
scala-package/macros/src/main/scala/org/apache/mxnet/SymbolMacro.scala
##########
@@ -48,67 +48,63 @@ private[mxnet] object SymbolImplMacros {
}
val newSymbolFunctions = {
- if (isContrib) symbolFunctions.filter(_._1.startsWith("_contrib_"))
- else symbolFunctions.filter(!_._1.startsWith("_contrib_"))
+ if (isContrib) symbolFunctions.filter(_.name.startsWith("_contrib_"))
+ else symbolFunctions.filter(!_.name.startsWith("_contrib_"))
+ }
+
+ var functionDefs = newSymbolFunctions map { symbolfunction =>
+ val funcName = symbolfunction.name
+ val tName = TermName(funcName)
+ q"""
+ @Deprecated
Review comment:
Will remove it in the next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
