larroy commented on issue #9853: Flaky test_operator.test_binary_op
URL: 
https://github.com/apache/incubator-mxnet/issues/9853#issuecomment-386875707
 
 
   I think the cause of this is that operator mod is using doubles to make the 
computation, while the test is forcing float32
   
   
https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_operator.py#L1511
   
https://github.com/apache/incubator-mxnet/blob/master/src/operator/mshadow_op.h#L402
   
   This discrepancy could be the cause of difference between results.
   
   >>> np.double(1.68) % np.double(1.30123)
   0.37876999999999983
   >>> np.float32(1.68) % np.float32(1.30123)
   0.37877
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to