anirudh2290 commented on a change in pull request #10833: [WIP] Change class
variables to thread local variables
URL: https://github.com/apache/incubator-mxnet/pull/10833#discussion_r186497893
##########
File path: python/mxnet/context.py
##########
@@ -60,18 +62,16 @@ class Context(object):
>>> gpu_array.context
gpu(1)
"""
- # static class variable
- default_ctx = None
Review comment:
@piiswrong told me that default_ctx, devtype2str and devstr2type where not
meant to be public API. This will also be renamed to _default_ctx. Users are
expected to use `current_context` or `default_context` in test_utils. I agree
though that this will break some existing code. I was of the opinion that the
release after 1.2 is 2.0 but I am not sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
