piiswrong commented on a change in pull request #10833: [WIP] Change class variables to thread local variables URL: https://github.com/apache/incubator-mxnet/pull/10833#discussion_r186499747
########## File path: python/mxnet/context.py ########## @@ -60,18 +62,16 @@ class Context(object): >>> gpu_array.context gpu(1) """ - # static class variable - default_ctx = None Review comment: If there are users who depend on this, we can make a backward compatible wrapper with classmethod and property:https://stackoverflow.com/questions/1697501/python-staticmethod-with-property ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services