eric-haibin-lin commented on a change in pull request #10946: Remove kvstore
calls from FM example
URL: https://github.com/apache/incubator-mxnet/pull/10946#discussion_r188834717
##########
File path: example/sparse/factorization_machine/train.py
##########
@@ -75,6 +76,16 @@
assert(args.data_train is not None and args.data_test is not None), \
"dataset for training or test is missing"
+ def batch_row_ids(data_batch):
+ """ Generate row ids based on the current mini-batch """
+ idx = batch.data[0].indices
Review comment:
I think mxnet returns a ordered list for NDArrayIter:
https://github.com/apache/incubator-mxnet/blob/master/python/mxnet/io.py#L520
short answer: don't use dict..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
