larroy commented on a change in pull request #10297: [MXNET-244] Fixes for 
cross compilation in ARM
URL: https://github.com/apache/incubator-mxnet/pull/10297#discussion_r190862619
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -40,19 +40,24 @@ build_jetson() {
     pushd .
     mv make/crosscompile.jetson.mk make/config.mk
     make -j$(nproc)
-
     export MXNET_LIBRARY_PATH=`pwd`/libmxnet.so
     cd /work/mxnet/python
-    python setup.py bdist_wheel --universal
+    build_wheel
+    popd
+}
 
-    # Fix pathing issues in the wheel.  We need to move libmxnet.so from the 
data folder to the
-    # mxnet folder, then repackage the wheel.
+build_wheel() {
+    set -ex
+    pushd .
+    python setup.py bdist_wheel --universal
     WHEEL=`readlink -f dist/*.whl`
     TMPDIR=`mktemp -d`
     unzip -d $TMPDIR $WHEEL
     rm $WHEEL
     cd $TMPDIR
     mv *.data/data/mxnet/libmxnet.so mxnet
+    cd $TMPDIR
+    #zip -r $WHEEL $TMPDIR
 
 Review comment:
   I think there were problems, this works.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to