eric-haibin-lin closed pull request #11058: [MXNET-473] Fix for dist_sync_kvstore and test_operator.test_op_roi_align URL: https://github.com/apache/incubator-mxnet/pull/11058
This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/src/operator/tensor/elemwise_binary_op-inl.h b/src/operator/tensor/elemwise_binary_op-inl.h index 2cf64818aba..c74f1f93603 100644 --- a/src/operator/tensor/elemwise_binary_op-inl.h +++ b/src/operator/tensor/elemwise_binary_op-inl.h @@ -552,7 +552,7 @@ void ElemwiseBinaryOp::DnsRspDnsOp(mshadow::Stream<xpu> *s, TBlob rsp_data = rsp.data(); TBlob rsp_indices = rsp.aux_data(rowsparse::kIdx); - MSHADOW_SGL_DBL_TYPE_SWITCH(rsp_data.type_flag_, DType, { + MSHADOW_TYPE_SWITCH(rsp_data.type_flag_, DType, { MSHADOW_IDX_TYPE_SWITCH(rsp_indices.type_flag_, IType, { MXNET_ASSIGN_REQ_SWITCH(req, Req, { if (reverse && std::is_same<OP, mshadow_op::minus>::value) { diff --git a/tests/python/unittest/test_operator.py b/tests/python/unittest/test_operator.py index c5bdee1d1e5..3f089717b78 100644 --- a/tests/python/unittest/test_operator.py +++ b/tests/python/unittest/test_operator.py @@ -6019,7 +6019,7 @@ def test_context_num_gpus(): if str(e).find("CUDA") == -1: raise e - + @with_seed() def test_op_roi_align(): # Adapted from https://github.com/wkcn/MobulaOP/blob/master/tests/test_roi_align_op.py @@ -6146,7 +6146,7 @@ def test_roi_align_value(): real_output, [dx, drois] = roialign_forward_backward(data.asnumpy(), rois.asnumpy(), pooled_size, spatial_scale, sampling_ratio, dy.asnumpy()) assert np.allclose(output.asnumpy(), real_output) # It seems that the precision between Cfloat and Pyfloat is different. - assert np.allclose(data.grad.asnumpy(), dx, atol = 1e-6), np.abs(data.grad.asnumpy() - dx).max() + assert np.allclose(data.grad.asnumpy(), dx, atol = 1e-5), np.abs(data.grad.asnumpy() - dx).max() assert np.allclose(rois.grad.asnumpy(), drois) # modified from test_roipooling() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services