szha commented on a change in pull request #11053: [MXNET-244] Fixed armv7 wheel
URL: https://github.com/apache/incubator-mxnet/pull/11053#discussion_r191837181
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -83,31 +102,40 @@ build_armv6() {
-DBUILD_CPP_EXAMPLES=OFF \
-Dmxnet_LINKER_LIBS=-lgfortran \
-G Ninja /work/mxnet
+
ninja
- export MXNET_LIBRARY_PATH=`pwd`/libmxnet.so
- cd /work/mxnet/python
- python setup.py bdist_wheel --universal
- cp dist/*.whl /work/build
+ build_wheel
+
popd
}
build_armv7() {
set -ex
pushd .
cd /work/build
- cmake\
- -DUSE_CUDA=OFF\
- -DUSE_OPENCV=OFF\
- -DUSE_OPENMP=OFF\
- -DUSE_SIGNAL_HANDLER=ON\
- -DCMAKE_BUILD_TYPE=RelWithDebInfo\
- -DUSE_MKL_IF_AVAILABLE=OFF\
+
+ # Lapack functionality will be included and statically linked to openblas.
Review comment:
It’s not about openblas itself, but rather whether the library requires
gfortran at runtime or not. If not, then a libgfortran’s .a file that was
compiled with -fPIC is required. You mentioned static linking in the comment so
I assumed that you meant a complete static linking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
